On Fri, May 04, 2012 at 04:47:13PM +0300, Alexander Shishkin wrote: > Hi, > > This is the 6th version of the patchset aiming to rework ci13xxx > driver. With this patchset, the driver also supports an older version > of chipidea found in Marvell's Feroceon SoC, that is, it works with > sheevaplug (provided you can find or make a USB A-to-A cable). > > This patchset fixes several bugs in the udc driver and addresses > some of the style issues. This patchset also includes conversion to > platform_device, which in case if msm is only compile-tested. While > at it, I have also converted "choice" of UDC controllers into a menu, > since we can probably have more than one UDC in the system, at least > theoretically. > > It also converts ci13xxx_udc to the "new style", so that we can finally > get rid of the global _udc pointer and theoretically can now have as > many chipidea gadgets in the system as we please. > > Then, it proceeds to move the driver to drivers/usb/chipidea and turn > it into a dual-role controller driver, complete with role switching > (manual and ID-pin based) and both device and host roles. Tested on > both sheevaplug and penwell. The former requires modifications to the > platform code in arch/arm, which are not part of these series. The > latter just works. > > Finally, it removes langwell_udc driver, as it is now covered by the > reworked chipidea driver too and adds a new entry in MAINTAINERS. > > New since the previous version: > * moved platform data of the pci driver to driver_data in pci_id > tables as Felipe suggested, > * split "new style" conversion into two patches, first of which moves > endpoint initialization from start() to probe(), per Felipe's request, > * fixed deferred address setting per Felipe's comment, > * minor fixes here and there per Felipe's comments, > * removed langwell_udc, > * added a MAINTAINERS entry > > Alexander Shishkin (27): Hi Alexander, It is really great work, I hope we can all switch to it in future. I go through your code, and would like to know your comments for below questions: - I have not found vbus interrupt code which is used to stand for connect and disconnect at device mode. - Seems hcd will register interrupt 0 irq handler, if the system has really interrupt 0 irq handler, it may mess up. - Current, there is no PHY Layer code (I will begin to do it soon), so your PHY operation is at udc code, once the PHY Layer code is ready, do you will move it to core.c? - What's your plan for low power mode and wakeup support? - When ID switch occurs, do udc_start/udc_stop is enough, seems no registers operation? Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
