Re: [Resend PATCH V2 3/7] usb: Set device removable state based on ACPI USB data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2012年05月09日 01:31, Greg KH wrote:
On Fri, May 04, 2012 at 11:06:39AM +0800, Lan Tianyu wrote:
From: Matthew Garrett<mjg@xxxxxxxxxx>

ACPI offers two methods that allow us to infer whether or not a USB port
is removable. The _PLD method gives us information on whether the port is
"user visible" or not. If that's not present then we can fall back to the
_UPC method which tells us whether or not a port is connectable.

Signed-off-by: Matthew Garrett<mjg@xxxxxxxxxx>
---
  drivers/usb/core/usb-acpi.c |   56 +++++++++++++++++++++++++++++++++++++++++++
  1 files changed, 56 insertions(+), 0 deletions(-)

This is getting frustrating...
Oh. So sorry to bring trouble with you. I found problem that we just tested
the patchset with usbcore built in kernel rather than as a module. So
carelessness.

After this patch I get the following build error:
	ERROR: "acpi_get_physical_device_location" [drivers/usb/core/usbcore.ko] undefined!

Lan, please retest these, and resend them, with Matthew's other ACPI
patch, after it's all working properly, and you have fixed this all up.
I've dropped all of these from my mailboxes now, you need to start over.

Also, when you forward on a patch like this, and the others, please also
sign-off-by: on it, or at least Ack: it, to keep you in the chain of bug
reporting and stuff.
Thanks for remind. I will do that.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
Best Regards
Tianyu Lan
linux kernel enabling team
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux