Re: [RFC PATCH] USB: serial: rework usb_serial_register/deregister_drivers()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 08, 2012 at 02:33:08PM -0700, Greg Kroah-Hartman wrote:
> > > @@ -396,8 +395,8 @@ do {									\
> > >  
> > >  /*
> > >   * module_usb_serial_driver() - Helper macro for registering a USB Serial driver
> > > - * @__usb_driver: usb_driver struct to register
> > >   * @__serial_drivers: list of usb_serial drivers to register
> > > + * @__ids: all device ids that @__serial_drivers bind to
> > 
> > Missing a line for @__name:
> 
> Ah, good catch.  This macro went through a zillion different variations,
> I was trying to embed KBUILD_MODNAME into it automagically for a while
> before giving up on that, which is why I forgot the @name usage.

No, wait, there is no name in macro, it is filled in automatically, so
the comments are correct here.

What a mess :)

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux