Re: USB: serial: ch341: remove reset_resume callback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 7 May 2012, Greg Kroah-Hartman wrote:

> > It looks like you're replacing a reset_resume method with a regular 
> > resume method.  Is that really the right thing to do?
> 
> As only 2 usb-serial drivers have ever implemented reset_resume, and
> they both did the same exact thing that their resume functions did, I
> think it is safe as resume will be called if reset_resume is not set,
> right?

Actually no.  If the device is going through a reset-resume and a 
driver's reset_resume method pointer isn't set, the driver will be 
unbound and then later rebound.  It's not a matter of just calling the 
resume method instead.

Although maybe for serial devices it doesn't make much difference.

Alan Stern


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux