Hello Felipe, On Friday, May 04, 2012 12:44 PM Felipe Balbi wrote: > -----Original Message----- > From: Felipe Balbi [mailto:balbi@xxxxxx] > Sent: Friday, May 04, 2012 12:44 PM > To: Andrzej Pietrasiewicz > Cc: linux-usb@xxxxxxxxxxxxxxx; Kyungmin Park; Greg Kroah-Hartman; Felipe Balbi; > Marek Szyprowski; Michal Nazarewicz; Benoit Goby; Mike Lockwood; Manu Gautam > Subject: Re: [PATCH 4/9] usb: gadget: Add variant of gether_setup to customize > the device name > > On Mon, Apr 23, 2012 at 01:36:20PM +0200, Andrzej Pietrasiewicz wrote: > > From: Mike Lockwood <lockwood@xxxxxxxxxxx> > > > > This is needed to avoid name collisions on SoCs that have both usb > > gadget and usb host, where usb0 may be the rndis interface or a usb > > ethernet adapter. > > > > Signed-off-by: Mike Lockwood <lockwood@xxxxxxxxxxx> > > Signed-off-by: Benoit Goby <benoit@xxxxxxxxxxx> > > [make gether_setup a static inline function] > > Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@xxxxxxxxxxx> > > Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > > breaks compilation: > > $ make -j8 drivers/usb/gadget/ > /dev/null In file included from > drivers/usb/gadget/ether.c:27:0: > drivers/usb/gadget/u_ether.h: In function ‘gether_setup’: > drivers/usb/gadget/u_ether.h:88:2: error: implicit declaration of function > ‘gether_setup_name’ [-Werror=implicit-function-declaration] I just posted a corrected version of patch 4/9 and 6/9. Together they contain exactly the same code, only the distribution of hunks is different between the two patches: now a function prototype is moved upwards in u_ether.h in patch 4/9, not 6/9. Thanks, Andrzej -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
