On Wed, May 2, 2012 at 5:29 PM, Jussi Kivilinna <jussi.kivilinna@xxxxxxxx> wrote: > Quoting Linus Walleij <linus.walleij@xxxxxxxxxx>: > >> The header file <linux/usb/rndis_host.h> used a number of #defines >> that included the cpu_to_le32() macro to assure the result will be >> in LE endianness. Inlining this into the code instead of using it >> in the code definitions yields consolidation opportunities later >> on as you will see in the following patches. The individual >> drivers also used local defines - all are switched over to the >> pattern of doing the conversion at the call sites instead. >> > > After this patch, endianness checks with sparse output: (...) > Patch fixing this attached. Thanks! Folded this into patch 1 and added your Signed-off-by. > Patch-set to clean-up ugliness caused by this patch at: > http://koti.mbnet.fi/axh/kernel/rndis_wlan/ This seems like a good middle-ground as compared to the other suggestion to force all defines to be cpu_to_le32(). Do you want me to rebase this on top of my series (there was a number of conflicts later in the series) and carry it as part of this patch set? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
