Re: [RESEND PATCH v5 00/18] usb:hsotg:samsung USB S3C-HSOTG driver fixes and code cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



hi,

On Fri, May 04, 2012 at 02:16:58PM +0200, Lukasz Majewski wrote:
> Presented patch series fix several problems with S3C-HSOTG driver, thus now
> the Multi Function Gadget (MFG) is working correctly.
> 
> Those commits consist of EP0 transfer management fixes (ZLP sending code
> and NAK management).
> Moreover the disconnect irq handler has been removed, since it is available only
> at HOST mode.
> 
> Code for recovering from device disconnection and connection during ongoing
> transfer has been added as well.
> 
> The s3c-hsotg driver has been adjusted to use newer usb_gadget_ops callbacks
> (namely udc_start and udc_stop) instead of deprecated ones.
> 
> Moreover number of EPs is now read from a HW configuration register instead
> of statically defined value.
> 
> The our_hsotg global variable has been removed and release function has been
> added as well to prevent warning messages.
> 
> Tested with:
>     - DFU gadget (various size of the sent data - also packet = MPS)
>     - Ethernet gadget (CDC and RNDIS)
>     - Multi Function Gadget (g_multi)
> 
> HW: 
>     - Samsung's C210 Universal rev.0
>     - Samsung's C110 GONI
> 
> ---
> Changes for v2:
> - Support for regulator_bulk_*
> - Number of EPs determined during runtime
> - Usage of udc_start and udc_stop methods instead of deprecated ones
> - Code preparation to move to dwc2 driver from s3c-hsotg
> 
> Changes for v3:
> - Comments refactored to comply with kernel coding style
> - Doxygen functions descriptions added
> - Removal of our_hsotg global pointer variable
> 
> Changes for v4:
> - Remove platform dependent code
> - Check if dynamically read number of EPs is not equal to zero
> - Release function added to prevent warnings
> 
> Changes for v5:
> - Remove S3C_ prefix for register's definition
> - Replace the clk_enable() with clk_prepare_enable() and clk_disable() with
>   clk_disable_unprepare()
> - error fallback code for failed request_irq

I have applied this series (finally :-). There were a couple of patches
I had to manually apply because they failed, please make sure my gadget
branch looks like you wanted ;-)

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux