Re: [PATCH v4 11/24] usb: gadget: ci13xxx: convert to new style

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Thu, May 03, 2012 at 04:12:52PM +0300, Alexander Shishkin wrote:
> On Thu, 3 May 2012 15:56:18 +0300, Felipe Balbi <balbi@xxxxxx> wrote:
> > On Wed, May 02, 2012 at 05:13:40PM +0300, Alexander Shishkin wrote:
> > > In order to function as a "newstyle" udc, move endpoint (de-)initialization
> > 
> > so first move the endpoint initialization part, then change to newstyle.
> > It'll be easier to review.
> 
> Won't it start looking like "Do $X so that the next patch makes sense",
> which doesn't seem to be a valid reason to change things? And as far as
> I'm corncerned, it's good to have a reason *why* things are changed in
> patch descriptions. But you're the maintainer, of course. :)

sounds like you're getting fed up with this series, but unfortunately I
will ask this to be splitted up. Moving the endpoint initialization to
probe will have no side-effects anyway and could be done even without
the goal of $SUBJECT. Sorry.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux