On Mon, 30 Apr 2012, Greg KH wrote: > On Wed, Apr 25, 2012 at 03:58:39PM -0400, Alan Stern wrote: > > This patch (as1547) rearranges the Power Management parts of the > > ehci-tegra driver to match the conventions used in other EHCI platform > > drivers. In particular, the controller should not be powered down by > > the root hub's suspend routine; the controller's power level should be > > managed by the controller's own PM methods. > > > > The end result of the patch is that the standard ehci_bus_suspend() > > and ehci_bus_resume() methods can be used instead of special-purpose > > routines. The driver now uses the standard dev_pm_ops methods instead > > of legacy power management. Since there is no supported wakeup > > mechanism for the controller, runtime suspend is forbidden by default > > (this can be overridden via sysfs, if desired). > > > > These adjustments are needed in order to make ehci-tegra compatible > > with recent changes to the USB core. The core now checks the root > > hub's status following bus suspend; if the controller is automatically > > powered down during bus suspend then the check will fail and the root > > hub will be resumed immediately. Doing the controller power-down in a > > separate method avoids this problem. > This patch doesn't apply cleanly on top of 3.4-rc5, but it does apply > cleanly on top of my usb-next branch. > > I thought this was to be included in 3.4-final, as that is where the > above referenced patch is contained, should this not be true? Stephen has sent in a few independent changes to ehci-tegra in the meantime. They are in your usb-next branch, and this patch was based on top of them. That's why it doesn't apply to 3.4-rc5. I'll submit a version based on your usb-linus branch in the next few days. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
