Re: [RFT 1/2] cdc-wdm: sanitize error returns

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Oliver Neukum <oneukum@xxxxxxx> writes:
> Am Freitag, 27. April 2012, 16:02:35 schrieb Bjørn Mork:
>
>> Right, so that's the problem with the 512 error returned to userspace...
>
> Then please test it together with commit 2c4d6bf295ae10ffcd84f0df6cb642598eb66603
> It was included in 3.3. I need to know whether this fixes your problem. I'd then
> backport it to older stable kernels.

Should have found that myself but had to run...  Builds fine with that
commit included.

But I have no idea which error codes are supposed to be returned and
which should be translated.  I can only assume the change is correct for
wdm_flush, but I wonder why we translate errors there and not anywhere
else? I still get the 

  error: couldn't open the QmiDevice: Version info check failed: Version info check failed: Cannot write message: Unknown error 512

from wdm_write for example.  Shouldn't that have caused as retry
somewhere?  Or is that a task for the application?

As you now understand, I am probably not the right person to test these
things. I don't know anything about IO error handling at all.  I did
read through the LDD3 once, but it's all starting to fade


Bjørn
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux