Re: [PATCH] USB: udc-core: fix incompatibility with dummy-hcd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Thu, Apr 26, 2012 at 11:31:57AM -0400, Alan Stern wrote:
> This patch (as1548) fixes a recently-introduced incompatibility
> between the UDC core and the dummy-hcd driver.  Commit
> 8ae8090c82eb407267001f75b3d256b3bd4ae691 (usb: gadget: udc-core: fix
> asymmetric calls in remove_driver) moved the usb_gadget_udc_stop()
> call in usb_gadget_remove_driver() below the usb_gadget_disconnect()
> call.
> 
> As a result, usb_gadget_disconnect() gets called at a time when the
> gadget driver believes it has been unbound but dummy-hcd believes
> it has not.  A nasty error ensues when dummy-hcd calls the gadget
> driver's disconnect method a second time.
> 
> To fix the problem, this patch moves the gadget driver's unbind
> notification after the usb_gadget_disconnect() call.  Now nothing
> happens between the two unbind notifications, so nothing goes wrong.
> 
> Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> Tested-by: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>

applied, thanks

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux