Hi,
On Thu, Apr 26, 2012 at 05:17:05PM +0300, Felipe Balbi wrote:
> This is basically a noop for DWC3. We don't have
> to do anything. Basically we test if the request
> parameters are correct, cache the Isochronous
> Delay and return success.
>
> Cc: Paul Zimmerman <paulz@xxxxxxxxxxxx>
> Signed-off-by: Felipe Balbi <balbi@xxxxxx>
> ---
>
> Paul, there's no mention on databook what we should do
> with this value. But without implementing this we will
> fail USB30CV and, thus, certification. For now we're just
> caching the value. If you know what we should do, do let
> me know and I will update the patch accordingly.
>
> drivers/usb/dwc3/core.h | 2 ++
> drivers/usb/dwc3/ep0.c | 27 +++++++++++++++++++++++++++
> 2 files changed, 29 insertions(+)
>
> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
> index 4149c1a..98b1e71 100644
> --- a/drivers/usb/dwc3/core.h
> +++ b/drivers/usb/dwc3/core.h
> @@ -565,6 +565,7 @@ struct dwc3_request {
> * @setup_packet_pending: true when there's a Setup Packet in FIFO. Workaround
> * @needs_fifo_resize: not all users might want fifo resizing, flag it
> * @resize_fifos: tells us it's ok to reconfigure our TxFIFO sizes.
> + * @isoch_delay: wValue from Set Isochronous Delay request;
> * @u2sel: parameter from Set SEL request.
> * @u2pel: parameter from Set SEL request.
> * @u1sel: parameter from Set SEL request.
> @@ -633,6 +634,7 @@ struct dwc3 {
> enum dwc3_link_state link_state;
> enum dwc3_device_state dev_state;
>
> + u16 isoch_delay;
> u16 u2sel;
> u16 u2pel;
> u8 u1sel;
> diff --git a/drivers/usb/dwc3/ep0.c b/drivers/usb/dwc3/ep0.c
> index 2950b6a..1da48ea 100644
> --- a/drivers/usb/dwc3/ep0.c
> +++ b/drivers/usb/dwc3/ep0.c
> @@ -572,6 +572,29 @@ static int dwc3_ep0_set_sel(struct dwc3 *dwc, struct usb_ctrlrequest *ctrl)
> return __dwc3_gadget_ep0_queue(dep, &dwc->ep0_usb_req);
> }
>
> +static int dwc3_ep0_set_isoch_delay(struct dwc3 *dwc, struct usb_ctrlrequest *ctrl)
> +{
> + struct dwc3_ep *dep;
this variable is unused. Already fixed locally. Will send final version
when Paul help us out understanding what we should do with the value ;-)
--
balbi
Attachment:
signature.asc
Description: Digital signature
