________________________________________ > From: David Miller [davem@xxxxxxxxxxxxx] > Sent: Wednesday, April 25, 2012 7:45 PM > To: Haiyang Zhang > Cc: linus.walleij@xxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; balbi@xxxxxx; jussi.kivilinna@xxxxxxxx; yongjun_wei@xxxxxxxxxxxxxxxxx; ben@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 02/14 v2] usb/net: rndis: break out <linux/rndis.h> defines > > From: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx> > Date: Wed, 25 Apr 2012 20:38:31 +0000 > > > Reviewed-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx> > > I don't think you really thoroughly reviewed this patch, otherwise > you would have noticed the duplicate definitions that result from > this patch which adds hundreds of warnings to the build. Actually, I did see the duplicate defines, I also noticed the author pointing out -- "The compilation screams about double-defines all over the place." In my test, the warnings go away after all patches applied. But, thanks for your comments. I believe the author has now realized that consolidating the defines and removing the duplicates should be done in one patch so that there are no warnings. Thanks, - Haiyang -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
