On Wed, Apr 25, 2012 at 03:58:39PM -0400, Alan Stern wrote: > This patch (as1547) rearranges the Power Management parts of the > ehci-tegra driver to match the conventions used in other EHCI platform > drivers. In particular, the controller should not be powered down by > the root hub's suspend routine; the controller's power level should be > managed by the controller's own PM methods. > > The end result of the patch is that the standard ehci_bus_suspend() > and ehci_bus_resume() methods can be used instead of special-purpose > routines. The driver now uses the standard dev_pm_ops methods instead > of legacy power management. Since there is no supported wakeup > mechanism for the controller, runtime suspend is forbidden by default > (this can be overridden via sysfs, if desired). > > These adjustments are needed in order to make ehci-tegra compatible > with recent changes to the USB core. The core now checks the root > hub's status following bus suspend; if the controller is automatically > powered down during bus suspend then the check will fail and the root > hub will be resumed immediately. Doing the controller power-down in a > separate method avoids this problem. > > Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> > CC: Stephen Warren <swarren@xxxxxxxxxxxxx> > CC: <stable@xxxxxxxxxxxxxxx> > > --- > > This patch should be applied to whichever trees have commit > 879d38e6bc36d73b0ac40ec9b0d839fda9fa8b1a (USB: fix race between > root-hub suspend and remote wakeup). Since that patch was marked for > -stable, I'm marking this one as well. No, that patch wasn't marked for stable in the end. I guess it was because this controller wasn't working properly yet with that change? > drivers/usb/host/ehci-tegra.c | 375 +++++++++++++++++++++--------------------- > 1 file changed, 195 insertions(+), 180 deletions(-) That's also a bit "big" for a stable patch. But it looks like the majority of this is moving the code around? Should this go in for 3.4-final as 879d38e6bc36d73b0ac40ec9b0d839fda9fa8b1a will make it into 3.4? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
