Re: [PATCH] USB: ci13xxx_udc: improve gadget.ep_list handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 23 Apr 2012 15:43:46 +0200, Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx> wrote:
> This patch fixes an issue and optimizes the gadget.ep_list handling:
> 
> - prevent null pointer dereference of wrong list_del_entry of ep0in and
> ep0out list_heads, which have never been added to the gadget.ep_list

This is fixed by this patch that I've sent some time ago:
http://marc.info/?l=linux-usb&m=133466625810959&w=2

> - its not necessary to remove every list entry by its own with
> list_del_init from the gadget.ep_list in the stop routine. To keep the
> list_heads several times reuseable, its better to reinitialize them on
> every start.

...and with the "new style" conversion patch, this is no longer an
issue: http://marc.info/?l=linux-usb&m=133466628010972&w=2 because the
endpoint initialization should happen at probe time, so that gadget's
bind() can run.

Regards,
--
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux