On 2012-04-18 09:58, Michael Grzeschik wrote:
> Make sure that dequeued urbs get handled first
> by collect_qtds. To achieve that we better move them
> up to the head in the qh list.
>
> This for instance fixes hanging serial devices, which wait
> for dequeued urbs to properly close their device node.
>
> Signed-off-by: Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx>
> ---
> drivers/usb/host/isp1760-hcd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/host/isp1760-hcd.c b/drivers/usb/host/isp1760-hcd.c
> index 37f017b..d4ffdc0 100644
> --- a/drivers/usb/host/isp1760-hcd.c
> +++ b/drivers/usb/host/isp1760-hcd.c
> @@ -1673,6 +1673,7 @@ static int isp1760_urb_dequeue(struct usb_hcd *hcd, struct urb *urb,
> list_for_each_entry(qtd, &qh->qtd_list, qtd_list)
> if (qtd->urb == urb) {
> dequeue_urb_from_qtd(hcd, qh, qtd);
> + list_move(&qtd->qtd_list, &qh->qtd_list);
> break;
> }
>
This looks good to me. Perhaps a comment to describe why the list_move is needed here?
Can you send a "v2" of this patch series including this updated patch?
--
Arvid Brodin
Enea Services Stockholm AB - since February 16 a part of Xdin in the Alten Group. Soon we
will be working under the common brand name Xdin. Read more at www.xdin.com.--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
