Re: [PATCH] USB: serial: ipaq: remove product and vendor module parameters

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 20, 2012 at 12:17:55PM +0200, Bjørn Mork wrote:
> Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> writes:
> 
> > @@ -45,7 +44,6 @@ static int  ipaq_calc_num_ports(struct u
> >  static int  ipaq_startup(struct usb_serial *serial);
> >  
> >  static struct usb_device_id ipaq_id_table [] = {
> > -	/* The first entry is a placeholder for the insmod-specified device */
> >  	{ USB_DEVICE(0x049F, 0x0003) },
> >  	{ USB_DEVICE(0x0104, 0x00BE) }, /* Socket USB Sync */
> >  	{ USB_DEVICE(0x03F0, 0x1016) }, /* HP USB Sync */
> 
> 
> Remove the first entry as well, then?  The same vid/pid is listed
> further down the table as
> 
>         { USB_DEVICE(0x049F, 0x0003) }, /* Compaq iPAQ USB Sync */
> 
> so you end up with a double alias definition:
> 
>  bjorn@canardo:~$ modinfo ipaq|grep 0003
>  alias:          usb:v049Fp0003d*dc*dsc*dp*ic*isc*ip*
>  alias:          usb:v049Fp0003d*dc*dsc*dp*ic*isc*ip*
> 
> 
> Only cosmetic of course, but you started ;-)

Ah, missed the double alias, thanks, I'll go remove that as well, thanks
for checking.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux