On Fri, Apr 20, 2012 at 02:44:48PM +0200, Marek Vasut wrote: > Dear Peter Chen, > > > On Fri, Apr 20, 2012 at 5:48 PM, Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> wrote: > > >> btw /wrt USB Gadget etc -- how does the > > >> drivers/usb/gadget/fsl_udc_core.c and drivers/usb/gadget/ci13xxx_* fit > > >> into the big picture? We're gonna use the ci13xxx stuff for Gadget on > > >> mx28, correct? Then how does fsl_udc_core.c fit in? > > > > > > From what I have been told by a collegue the ci13xxx driver works > > > better, and from what I have seen the code looks better. So I think mxs > > > should use it. i.MX can then use it later aswell. We won't need the > > > fsl_udc_core driver anymore then. > > > > Oh, I find I lost many discussions using company email. > > From the function and quality level, fsl_udc_core.c is absolutely the > > best one for all > > i.mx SoCs, as both internal and upstream fsl code use it. > > Internally though, it looks like crap. +1 on this. > Also, ci13xxx and fsl_usb_core is duplicated stuff, correct? Yes. > > > I will check with IC guys to see if i.mx's controller is compatible > > with CI13412. > > If fsl's compatible with CI13412, then mxs can try to use ci13xxx_udc.c to > > see if there are any problems, If no problems with kinds of testing, > > we can switch all i.mx SoC to ci13xxx_udc.c. > > Sascha, did you need to patch this ci13xxx somehow to get it running on MXS ? Or > what was it that said he got it somehow running? It basically works out of the box. I think we have some patches for this driver, maybe michael can comment on this. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
