Re: [PATCH v1 1/1] USB: EHCI: remove wrong debug message for port speed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 19, 2012 at 02:59:19AM +0000, Chen Peter-B29397 wrote:
>  
> > -----Original Message-----
> > From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx]
> > Sent: Thursday, April 19, 2012 4:46 AM
> > To: Chen Peter-B29397
> > Cc: stern@xxxxxxxxxxxxxxxxxxx; tom.leiming@xxxxxxxxx; linux-
> > usb@xxxxxxxxxxxxxxx
> > Subject: Re: [PATCH v1 1/1] USB: EHCI: remove wrong debug message for
> > port speed
> > 
> > On Thu, Mar 29, 2012 at 09:50:06AM +0800, Peter Chen wrote:
> > > It displays wrong debug message if we plug in a full/low
> > > speed device at port for builtin TT controller. We can get
> > > device/port speed information at following code of hub_port_init,
> > > so it is better to replace it with debug message of "reset complete".
> > >
> > > CC: <stable@xxxxxxxxxxxxxxx>
> > 
> > I'll apply this, but I don't think it fits the stable_kernel_rules.txt
> > guidelines at all, so I'm dropping the stable mark for it, ok?
> > 
> It is ok for me. By the way, which rules this patch breaks?
> 
> - It must fix a real bug that bothers people (not a, "This could be a
>    problem..." type thing).
> or
> - It cannot contain any "trivial" fixes in it (spelling changes,
>    whitespace cleanups, etc).
> or other rules?

You are changing the wording on a kernel log message that is only
enabled when debugging is enabled, something no "real" user would ever
find to be an issue.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux