On Wed, 18 Apr 2012 20:49:22 +0300, Felipe Balbi <balbi@xxxxxx> wrote: > pullup() is already called properly by udc-core.c and > there's no need to call it from udc_stop(), in fact that > will cause issues. > > Reported-by: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx> Well, the problem that I reported is technically still there, so I don't know if my reported-by is really valid here. But this patch is obviously correct, so you can add Reviewed-by me, for what it's worth. > Signed-off-by: Felipe Balbi <balbi@xxxxxx> > --- > drivers/usb/gadget/dummy_hcd.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/usb/gadget/dummy_hcd.c b/drivers/usb/gadget/dummy_hcd.c > index a6dfd21..170cbe8 100644 > --- a/drivers/usb/gadget/dummy_hcd.c > +++ b/drivers/usb/gadget/dummy_hcd.c > @@ -927,7 +927,6 @@ static int dummy_udc_stop(struct usb_gadget *g, > > dum->driver = NULL; > > - dummy_pullup(&dum->gadget, 0); > return 0; > } > > -- > 1.7.10 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
