On Wed, 18 Apr 2012 17:40:10 +0100
Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> On Wed, Apr 18, 2012 at 04:27:22PM +0300, Felipe Balbi wrote:
> > On Tue, Apr 17, 2012 at 09:22:00AM +0200, Lukasz Majewski wrote:
>
> > > This commit adds support for supply voltage management for
> > > s3c-hsotg IP block. For that purpose a convenient
> > > regulator_bulk_* functions have been used.
>
> > this needs to be reviewed by regulator folks, adding them to Cc.
>
> Looks fine, though you'll need to make sure you let all the relevant
> board maintainers know they'll need to add the supplies for the
> device.
All devices concerned with the s3c-hsotg already defines required
regulators:
e.g.
arch/arm/mach-exynos/mach-nuri.c:378: REGULATOR_SUPPLY("vusb_d",
"s3c-hsotg"), /* USB */
arch/arm/mach-exynos/mach-nuri.c:394: REGULATOR_SUPPLY("vusb_a",
"s3c-hsotg"), /* USB */
>
> In general the regulator API is pretty straightforward for stuff like
> this - same pattern as clock and whatever.
I'm trying to comply with the well established pattern :-)
--
Best regards,
Lukasz Majewski
Samsung Poland R&D Center
Platform Group
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
