On Thu, Apr 19, 2012 at 02:54:18AM +0000, Chen Peter-B29397 wrote: > > > > > > > > > How about create a patch changing name from ehci-mxc to ehci-imx first, > > then add > > > mx28/mx23/mx6q host ehci driver. I can do it. > > > > ehci-imx won't need clock handling and it won't need phy handling. Also > > the setup of the portsc register won't be in the new driver. The > > clk_get(dev, "usb_phy1") part is horribly broken anyway. It's more than > > just a rename. > > > It depends on how you want things to go on, you can > - Create ehci-mxs first, then clean up clk/phy at ehci-mxs/ehci-mxc after > generic phy driver and i.mx usb DT support is added, then merge ehci-mxs > and ehci-mxc to one ehci-imx. Not sure usb maintainers agree it or not. My idea is more to create a ehci-mxs and instead of cleaning up ehci-mxc we switch i.MX over to the new driver and remove ehci-mxc. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html