Re: [PATCH v4 03/15] usb:hsotg:samsung: Wrappers for USB PHY methods

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 17, 2012 at 09:21:59AM +0200, Lukasz Majewski wrote:
> Wrappers for PHY methods have been added for readability and reduction
> of code repetition.
> 
> Signed-off-by: Lukasz Majewski <l.majewski@xxxxxxxxxxx>
> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> 
> Conflicts:
> 
> 	drivers/usb/gadget/s3c-hsotg.c

again with the conflicts... Please clean up your commit log ;-)

Also, I would really like to see the PHY driver moved to
drivers/usb/otg/. But it can be done later.

> @@ -3317,6 +3350,9 @@ static int __devinit s3c_hsotg_probe(struct platform_device *pdev)
>  
>  	clk_enable(hsotg->clk);
>  
> +	/* usb phy enable */
> +

blank line is unnecessary.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux