> From: Paul Zimmerman
> Sent: Tuesday, April 17, 2012 1:09 PM
< snip >
> @@ -981,14 +981,12 @@ static void qh_link_async (struct ehci_h
> > head = ehci->async;
> > timer_action_done (ehci, TIMER_ASYNC_OFF);
> > if (!head->qh_next.qh) {
> > - u32 cmd = ehci_readl(ehci, &ehci->regs->command);
> > -
> > - if (!(cmd & CMD_ASE)) {
> > + if (!(ehci->command & CMD_ASE)) {
> > /* in case a clear of CMD_ASE didn't take yet */
> > (void)handshake(ehci, &ehci->regs->status,
> > STS_ASS, 0, 150);
> > - cmd |= CMD_ASE;
> > - ehci_writel(ehci, cmd, &ehci->regs->command);
> > + ehci->command |= CMD_ASE;
> > + ehci_writel(ehci, ehci->command, &ehci->regs->command);
>
> It seems that the comment is not valid anymore. Since you are not
> reading from the command register here, there is no way to tell
> whether "a clear of CMD_ASE didn't take yet". It seems this is a
> change in the behavior of the driver.
Never mind this one, I misread what the code is doing. Sorry for
the noise.
--
Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
