> +/* MCS7810 LED support */
> +#define MCS7810_HAS_LED
I would just enable this. Nobody is going to change it in their source
code.
> +#ifdef MCS7810_HAS_LED
> + /* Turn on MCS7810 LED */
> + if (serial->num_ports == 1 && mos7840_port->mos7810_led_flag == 0) {
Same comment as before about leds and flags to indicate features.
All these if cases should be a feature flag of some kind
Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
