On Wed, Apr 11, 2012 at 01:51:10PM -0700, Sarah Sharp wrote:
> Hi Greg,
>
> Someone reported a USB build error to me, but I don't think it's from
> any patch I wrote. It's against Linus' latest tree.
>
> It looks like the linker warning references the usb_speed_string() line
> that was introduced by this commit:
>
> commit e538dfdae85244fd2c4231725d82cc1f1bc4942c
> Author: Michal Nazarewicz <mina86@xxxxxxxxxx>
> Date: Tue Aug 30 17:11:19 2011 +0200
>
> usb: Provide usb_speed_string() function
>
> In a few places in the kernel, the code prints
> a human-readable USB device speed (eg. "high speed").
> This involves a switch statement sometimes wrapped
> around in ({ ... }) block leading to code repetition.
>
> To mitigate this issue, this commit introduces
> usb_speed_string() function, which returns
> a human-readable name of provided speed.
>
> It also changes a few places switch was used to use
> this new function. This changes a bit the way the
> speed is printed in few instances at the same time
> standardising it.
>
> Signed-off-by: Michal Nazarewicz <mina86@xxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
>
> But that's a pretty old commit, so I'm not sure why it's showing up now.
> Michal, do you know why this linker failure would happen?
>
> All the info I have is attached, including the .config file I used to
> confirm the build failure.
It looks like somehow CONFIG_USB_SUPPORT is disabled, which might be the
issue here.
I don't really care about 'randconfig' errors like this, unless they
come with a patch, as the odds of hitting them by a "real" user are
almost impossible.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
