On Tue, Apr 10, 2012 at 02:31:01AM +0000, Chen Peter-B29397 wrote: > > > > > > On Mon, 9 Apr 2012, Peter Chen wrote: > > > > > I have run this patch at FSL board, > > > > Using which driver? > > > This driver has still not mainlined, it implement low power mode at bus suspend, > the controller suspend is for ID switch and adjust wakeup flag during system suspend routine. > > > > and found the kernel is hang at reading > > > portsc of above code, the reason is controller is off after bus suspend. > > I > > > have checked the ehci-tegra.c, it also powers off its controller at bus > > > suspend, maybe there are other controllers also do that. > > > > Then we need to fix the drivers. The controller power is supposed to > > be turned off during controller suspend, not during bus suspend. > > > I agreee. > > > As far as I can see, ehci-tegra.c is the only EHCI driver which > > doesn't use ehci_bus_suspend as its bus_suspend routine. > > > > On the other hand, this probably means the patch series should not be > > merged into the stable kernel trees. Hm, I took off the stable marking here, should that still be true? If not, please let me know. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html