Re: [PATCH] USB: fix bug in serial driver unregistration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 9 Apr 2012, Greg KH wrote:

> On Wed, Mar 28, 2012 at 04:10:49PM -0400, Alan Stern wrote:
> > This patch (as1536) fixes a bug in the USB serial core.  Unloading and
> > reloading a serial driver while a serial device is plugged in causes
> > errors because of the code in usb_serial_disconnect() that tries to
> > make sure the port_remove method is called.  With the new order of
> > driver registration introduced in the 3.4 kernel, this is definitely
> > not the right thing to do (if indeed it ever was).
> > 
> > The patch removes that whole section code, along with the mechanism
> > for keeping track of each port's registration state, which is no
> > longer needed.  The driver core can handle all that stuff for us.
> > 
> > Note: This has been tested only with one or two USB serial drivers.
> > In theory, other drivers might still run into trouble.  But if they
> > do, it will be the fault of the drivers, not of this patch -- that is,
> > the drivers will need to be fixed.
> > 
> > Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> > Reported-and-tested-by: Johan Hovold <jhovold@xxxxxxxxx>
> 
> This just needs to go to 3.4-final, not 3.3-stable, right?

That's right, because the usb_serial_register_drivers thing never went
into 3.3-stable.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux