Re: [PATCH 2/2] USB: serial: removed assignment from if statements in ti_usb_3410_5052.c Removed the assignment statements found in if statements by the checkpatch.pl tool.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 09-04-2012 16:01, Adhir Ramjiawan wrote:

   Your changelog probably got concatenated to the patch's subject.

Signed-off-by: Adhir Ramjiawan<adhirramjiawan0@xxxxxxxxx>
---
  drivers/usb/serial/ti_usb_3410_5052.c |    8 ++++++--
  1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/serial/ti_usb_3410_5052.c b/drivers/usb/serial/ti_usb_3410_5052.c
index ab74123..82116f4 100644
--- a/drivers/usb/serial/ti_usb_3410_5052.c
+++ b/drivers/usb/serial/ti_usb_3410_5052.c
@@ -394,7 +394,9 @@ static int ti_startup(struct usb_serial *serial)

  	/* if we have only 1 configuration, download firmware */
  	if (dev->descriptor.bNumConfigurations == 1) {
-		if ((status = ti_download_firmware(tdev)) != 0)
+		status = ti_download_firmware(tdev);
+

   Empty line not needed here.

+		if (status != 0)
  			goto free_tdev;

  		/* 3410 must be reset, 5052 resets itself */
@@ -1683,7 +1685,9 @@ static int ti_download_firmware(struct ti_device *tdev)
  	/* try ID specific firmware first, then try generic firmware */
  	sprintf(buf, "ti_usb-v%04x-p%04x.fw", dev->descriptor.idVendor,
  	    dev->descriptor.idProduct);
-	if ((status = request_firmware(&fw_p, buf,&dev->dev)) != 0) {
+	status = request_firmware(&fw_p, buf,&dev->dev);
+

   Same here.

+	if (status != 0) {
  		buf[0] = '\0';
  		if (dev->descriptor.idVendor == MTS_VENDOR_ID) {
  			switch (dev->descriptor.idProduct) {

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux