On 04/03/2012 04:11 PM, Alan Stern : > On Tue, 3 Apr 2012, Nicolas Ferre wrote: > >> Change number of ports to 3 for newer SoCs. Modify pdata structure >> and ohci-at91 code that was dealing with ports information and check >> of port indexes. >> >> Signed-off-by: Nicolas Ferre <nicolas.ferre@xxxxxxxxx> >> Acked-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@xxxxxxxxxxxx> > > Did you run this patch through scripts/checkpatch.pl? I have the > feeling that it might complain about some of the changes. Yes, definitively. I can modify the patch to comply with error issued by checkpatch.pl: several are due to a bad replacement of previous code with my regular expression but others where existing before my modifications. So what do you think about: - addressing all style errors in this patch (to prevent carrying them) - merging this one and the following patch: "[PATCH v2 07/13] USB: ohci-at91: coding style modifications with one-line ifs - posting a v3 of this patch only if you agree on this... Best regards, -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html