Re: [PATCH] usb: fix wrong Kconfig menu level

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 01-04-2012 7:20, Feng King wrote:

quoted in Documentation/kbuild/kconfig-language.txt
"If a menu entry somehow depends on the previous entry, it
can be made a submenu of it. First, the previous (parent) symbol must
be part of the dependency list and then one of these two conditions
must be true:
- the child entry must become invisible, if the parent is set to 'n'
- the child entry must only be visible, if the parent is visible"
in commit 53c6bc24(usb: Don't make USB_ARCH_HAS_{XHCI,OHCI,EHCI} depend
on USB_SUPPORT.), we move if USB_SUPPORT several config items after
CONFIG_USB_SUPPROT, and break that rule, so usb config items will appear
at the same menu level as USB_SUPPORT. we can fix this either move
CONFIG_USB_SUPPORT just before if USB_SUPPORT, or use menu... endmenu
instead.

Signed-off-by: Feng King<ronyjin@xxxxxxxxxxx>
---
  drivers/usb/Kconfig |   16 ++++++++--------
  1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
index cbd8f5f..76316a3 100644
--- a/drivers/usb/Kconfig
+++ b/drivers/usb/Kconfig
@@ -2,14 +2,6 @@
  # USB device configuration
  #

-menuconfig USB_SUPPORT
-	bool "USB support"
-	depends on HAS_IOMEM
-	default y
-	---help---
-	  This option adds core support for Universal Serial Bus (USB).
-	  You will also need drivers from the following menu to make use of it.
-
  # many non-PCI SOC chips embed OHCI
  config USB_ARCH_HAS_OHCI
  	boolean
@@ -63,6 +55,14 @@ config USB_ARCH_HAS_XHCI
  	boolean
  	default PCI

+menuconfig USB_SUPPORT
+	bool "USB support"
+	depends on HAS_IOMEM
+	default y
+	---help---
+	  This option adds core support for Universal Serial Bus (USB).
+	  You will also need drivers from the following menu to make use of it.
+
  if USB_SUPPORT

  config USB_COMMON

Analagous patch was already submitted by David Daney (the author of the original breakage).

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux