> From: Alan Stern [mailto:stern@xxxxxxxxxxxxxxxxxxx] > Sent: Friday, March 30, 2012 12:17 PM > > On Thu, 29 Mar 2012, Paul Zimmerman wrote: > > > Enable the usbtest driver to test peripherals with super speed > > isoc endpoints. So far this has only been tested with the modified > > gadget zero with isoc endpoint support. > > > > A module parameter 'need_iso' is added to force the driver to look > > for an alternate interface containing isoc endpoints, instead of > > stopping at the first one with bulk endpoints. > > ... > > > @@ -1025,7 +1037,10 @@ test_ctrl_queue(struct usbtest_dev *dev, struct usbtest_param *param) > > case 13: /* short read, resembling case 10 */ > > req.wValue = cpu_to_le16((USB_DT_CONFIG << 8) | 0); > > /* last data packet "should" be DATA1, not DATA0 */ > > - len = 1024 - udev->descriptor.bMaxPacketSize0; > > + if (udev->speed == USB_SPEED_SUPER) > > + len = 512; > > + else > > + len = 1024 - udev->descriptor.bMaxPacketSize0; > > What's this doing here? It has nothing to do with $SUBJECT. > > > @@ -1388,7 +1403,10 @@ static int halt_simple(struct usbtest_dev *dev) > > int retval = 0; > > struct urb *urb; > > > > - urb = simple_alloc_urb(testdev_to_usbdev(dev), 0, 512); > > + if (testdev_to_usbdev(dev)->speed == USB_SPEED_SUPER) > > + urb = simple_alloc_urb(testdev_to_usbdev(dev), 0, 1024); > > + else > > + urb = simple_alloc_urb(testdev_to_usbdev(dev), 0, 512); > > Same thing here. Yep, you're right. These two should be a separate patch. Will respin. -- Paul -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
