> On Tue, 27 Mar 2012, Peter Chen wrote:
>
> > It displays wrong debug message if we plug in a full/low
> > speed device at port.
>
> This depends on the hardware. If the controller has a builtin TT then
> yes, it will display an incorrect speed. If it doesn't, this message
> won't appear when a full/low-speed device is attached.
>
> > We can get device/port speed information
> > at following code of hub_port_init, so it is ok to delete it.
>
> Agreed. However, instead of simply removing this message, I think it
> would be better also to remove the earlier message about "full speed
> --> companion", and instead put a new message near the start of the
> routine (just after the first "if" statement):
>
> ehci_dbg(ehci, "port %d reset complete: enable %d\n",
> index + 1, !!(port_status & PORT_PE));
>
I have no experiences on controller without build-in TT. According to your words,
When a full/low speed device attaches, without build-in TT controller's PE will still
be 0 even reset completes. So:
ehci_dbg (ehci, "port %d full speed --> companion\n",
index + 1);
may be useful for them.
How about only change the code like below:
diff --git a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/ehci-hub.c
index 77bbb23..7e35e59 100644
--- a/drivers/usb/host/ehci-hub.c
+++ b/drivers/usb/host/ehci-hub.c
@@ -536,7 +536,9 @@ static int check_reset_complete (
if (ehci->has_amcc_usb23)
set_ohci_hcfs(ehci, 1);
} else {
- ehci_dbg (ehci, "port %d high speed\n", index + 1);
+ if (!ehci_is_TDI(ehci)) {
+ ehci_dbg (ehci, "port %d high speed\n", index + 1);
+ }
/* ensure 440EPx ohci controller state is suspended */
if (ehci->has_amcc_usb23)
set_ohci_hcfs(ehci, 0);
> In fact, if you do this then you might even want to remove the message
> about "Failed to enable port %d on root hub TT".
>
> Alan Stern
>
> > Signed-off-by: Peter Chen <peter.chen@xxxxxxxxxxxxx>
> > ---
> > drivers/usb/host/ehci-hub.c | 1 -
> > 1 files changed, 0 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/ehci-hub.c
> > index 256fbd4..3dd83c3 100644
> > --- a/drivers/usb/host/ehci-hub.c
> > +++ b/drivers/usb/host/ehci-hub.c
> > @@ -536,7 +536,6 @@ static int check_reset_complete (
> > if (ehci->has_amcc_usb23)
> > set_ohci_hcfs(ehci, 1);
> > } else {
> > - ehci_dbg (ehci, "port %d high speed\n", index + 1);
> > /* ensure 440EPx ohci controller state is suspended */
> > if (ehci->has_amcc_usb23)
> > set_ohci_hcfs(ehci, 0);
> >
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
