On Tue, Mar 27, 2012 at 4:53 PM, Peter Chen <peter.chen@xxxxxxxxxxxxx> wrote:
> It displays wrong debug message if we plug in a full/low
> speed device at port. We can get device/port speed information
> at following code of hub_port_init, so it is ok to delete it.
Looks the debug message is not for providing speed info, but for
diagnosing ehci port reset, so deleting it simply is not good.
> Signed-off-by: Peter Chen <peter.chen@xxxxxxxxxxxxx>
> ---
> drivers/usb/host/ehci-hub.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/ehci-hub.c
> index 256fbd4..3dd83c3 100644
> --- a/drivers/usb/host/ehci-hub.c
> +++ b/drivers/usb/host/ehci-hub.c
> @@ -536,7 +536,6 @@ static int check_reset_complete (
> if (ehci->has_amcc_usb23)
> set_ohci_hcfs(ehci, 1);
> } else {
> - ehci_dbg (ehci, "port %d high speed\n", index + 1);
The check should be correct, see "2.3.9 PORTSC" of ehci spec:
Port Enabled/Disabled R/W.
The host controller will only set this bit to a one when
the reset sequence determines that the attached device is a
high-speed device.
So maybe you should check why your ehci reports it
mistakenly.
> /* ensure 440EPx ohci controller state is suspended */
> if (ehci->has_amcc_usb23)
> set_ohci_hcfs(ehci, 0);
Thanks,
--
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
