Re: [PATCH v3 1/5] ptp-gadget: Fix issue in enum_object

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 27 Mar 2012, Anatolij Gustschin wrote:

> On Sun, 25 Mar 2012 22:44:08 +0200 (CEST)
> Guennadi Liakhovetski <g.liakhovetski@xxxxxx> wrote:
> ...
> > How about this commit message:
> > 
> > From readdir(3): "According to POSIX, the dirent structure contains a
> > field char d_name[] of  unspecified  size,  with  at most NAME_MAX
> > characters preceding the terminating null byte." In recent Linux versions
> > d_name is declared as a zero-size array, and is allocated dynamically at
> > run-time. Therefore calling sizeof() for this struct member is wrong and
> > useless.
> 
> Okay, I'll resubmit the patch and add the suggested commit message.

There's no need for that, if you agree with it, I'll just use it, when 
pushing.

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux