Re: [PATCH v2 2/5] ptp-gadget: Add delete object support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Anatolij

I finally found some time to look at this new version of your patches and 
to actually try to commit them, however

On Wed, 8 Feb 2012, Anatolij Gustschin wrote:

[snip]

> > > +	if (length > 16 && format != PTP_PARAM_UNUSED) {
> > 
> > I think, you can allow format == PTP_PARAM_ANY at no additional cost - you 
> > anyway support deletion of all objects, and they are all images so far...
> 
> No, subsequent patches add support for text file objects, so not

...speaking about which - what's your plan concerning patches 3-5? AFAICS, 
my last comments to them have not been addressed. Are you planning to 
update them too, or would you like to first get patches 1 and 2 pushed and 
want to deal with the rest later?

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux