Re: [PATCH 2/2 v2] xHCI: add XHCI_RESET_ON_RESUME quirk for VIA xHCI host

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 26, 2012 at 08:46:23PM +0800, Elric Fu wrote:
> The suspend operation of VIA xHCI host have some issues and
> hibernate operation works fine, so The XHCI_RESET_ON_RESUME
> quirk is added for it.
> 
> This patch should base on "xHCI: Don't write zeroed pointer
> to xHC registers" that is released by Sarah. Otherwise, the
> host system error will ocurr in the hibernate operation
> process.

This patch doesn't apply on top of the patch you mentioned.  What's
missing is there is no section for checking the VIA PCI vendor ID.  You
added that in your VIA firmware printing patch.

What I want is this patch (by itself) to apply to my for-usb-linus-queue
branch that is destined to be merged into 3.4.  Then I can mark just
that patch for stable.  You'll need to move some of the code from the
firmware printing patch into this patch to make it apply.  So checkout
the for-usb-linus-queue and make sure this patch applies before
resending it.

Once you've changed this patch to be first in your series, rebase the
firmware printing patch on top of that.  Resend it, and I will queue it
for the 3.5 merge window.

If you have any questions about this, don't hesitate to ask.

Sarah Sharp

> 
> Signed-off-by: Elric Fu <elricfu1@xxxxxxxxx>
> ---
>  drivers/usb/host/xhci-pci.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> index 872d024c..75350ea 100644
> --- a/drivers/usb/host/xhci-pci.c
> +++ b/drivers/usb/host/xhci-pci.c
> @@ -106,6 +106,7 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
>  	}
>  	if (pdev->vendor == PCI_VENDOR_ID_VIA) {
>  		xhci->quirks |= XHCI_VIA_HOST;
> +		xhci->quirks |= XHCI_RESET_ON_RESUME;
>  		xhci_via_get_fw(xhci, pdev);
>  	}
>  }
> -- 
> 1.7.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux