RE: usbcore and root-hub suspend/wakeup races

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 24 Mar 2012, Chen Peter-B29397 wrote:

> You may forget somewhere to set resuming_ports, a patch like below may be needed.
> 
> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
> index a007a9f..3f8a67f 100644
> --- a/drivers/usb/host/ehci-hcd.c
> +++ b/drivers/usb/host/ehci-hcd.c
> @@ -941,6 +941,7 @@ static irqreturn_t ehci_irq (struct usb_hcd *hcd)
>                          */
>                         ehci->reset_done[i] = jiffies + msecs_to_jiffies(25);
>                         ehci_dbg (ehci, "port %d remote wakeup\n", i + 1);
> +                       set_bit(i, &ehci->resuming_ports);
>                         mod_timer(&hcd->rh_timer, ehci->reset_done[i]);
>                 }
>         }

You're right.  Or rather, I didn't forget to add that line but I did 
forget to add ehci-hcd.c into the patch.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux