On Fri, Mar 23, 2012 at 01:38:38PM +0900, Nobuhiro Iwamatsu wrote: > Paul Mundt ????????????????????????: > >On Wed, Mar 21, 2012 at 03:47:00PM +0900, Nobuhiro Iwamatsu wrote: > >>In devices using ehci-sh, initialization of the PHY may be necessary. > >>This adds platform data to ehci-sh and provide function to initialize PHY. > >> > >>Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@xxxxxxxxxxx> > >>CC: Shimoda Yoshihiro <yoshihiro.shimoda.uh@xxxxxxxxxxx> > > > >It's impossible to say whether this makes sense or not without first > >seeing what you are trying to do in the callback. > > > > For example, it is necessary to initialize it after having > ebabled clock of ehci in sh7734. > I perform initialization CPU specific in callback. > For example, following. > Ok, that seems fine. I'd prefer to see the header in include/linux/platform_data/, however. Also, when can we expect an upstream user for this? I don't mind adding support for it, but it doesn't make much sense to have upstream if there aren't any in-tree users. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
