Hi,
On Wed, Mar 21, 2012 at 04:32:09PM +0100, Lukasz Majewski wrote:
> On Wed, 21 Mar 2012 15:07:55 +0200
> Felipe Balbi <balbi@xxxxxx> wrote:
>
> Hi Felipe,
>
> > On Wed, Mar 21, 2012 at 12:59:49PM +0100, Lukasz Majewski wrote:
> > > Replace of deprecated start and stop callbacks with a udc_start and
> > > udc_stop ones.
> > >
> > > Now the bind from composite driver is NOT called explicitly, so more
> > > work needs to be done at s3c_udc_probe. Especially enabling SoC
> > > clocks and power for runtime determination of EP number.
> > > After probing, those sources are disabled and enabled again at
> > > udc_start and pullup afterwards.
> > >
> > > Signed-off-by: Lukasz Majewski <l.majewski@xxxxxxxxxxx>
> > > Signed-off-by: Sangwook Lee <sangwook.lee@xxxxxxxxxx>
> > > Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> > > ---
> > > drivers/usb/gadget/s3c-hsotg.c | 61
> > > +++++++++++++++++++++++---------------- 1 files changed, 36
> > > insertions(+), 25 deletions(-)
> > >
> > > diff --git a/drivers/usb/gadget/s3c-hsotg.c
> > > b/drivers/usb/gadget/s3c-hsotg.c index cdde51c..9925661 100644
> > > --- a/drivers/usb/gadget/s3c-hsotg.c
> > > +++ b/drivers/usb/gadget/s3c-hsotg.c
> > > @@ -2815,8 +2815,8 @@ static void s3c_hsotg_init(struct s3c_hsotg
> > > *hsotg) hsotg->regs + S3C_GAHBCFG);
> > > }
> > >
> > > -static int s3c_hsotg_start(struct usb_gadget_driver *driver,
> > > - int (*bind)(struct usb_gadget *))
> > > +static int s3c_hsotg_udc_start(struct usb_gadget *gadget,
> > > + struct usb_gadget_driver *driver)
> > > {
> > > struct s3c_hsotg *hsotg = our_hsotg;
> >
> > you should also remove this our_hsotg global while at that.
> >
>
> It is a good idea to remove this global.
> I will prepare and include to v3 another patch which removes this.
yeah, removing all those global pointers was one of the motivations for
introducing udc_start/udc_stop ;-) After everybody is converted to these
new fields, we will drop the old ones and rename udc_start/udc_stop to
plain start/stop ;-)
--
balbi
Attachment:
signature.asc
Description: Digital signature
