Hello. On 21-03-2012 15:59, Lukasz Majewski wrote:
Wrappers for PHY methods have been added for readability and reduction of code repetition.
Signed-off-by: Lukasz Majewski<l.majewski@xxxxxxxxxxx> Signed-off-by: Kyungmin Park<kyungmin.park@xxxxxxxxxxx> --- drivers/usb/gadget/s3c-hsotg.c | 47 ++++++++++++++++++++++++++++++++++------ 1 files changed, 40 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c index 6dab16a..4170654 100644 --- a/drivers/usb/gadget/s3c-hsotg.c +++ b/drivers/usb/gadget/s3c-hsotg.c @@ -2570,6 +2570,41 @@ static int s3c_hsotg_corereset(struct s3c_hsotg *hsotg) return 0; } +/** + * s3c_hsotg_phy_enable - enable platform phy dev + * + * @param: The driver state + * + * A wrapper for platform code responsible for controlling + * low-level USB code + */ +static void s3c_hsotg_phy_enable(struct s3c_hsotg *hsotg) +{ + struct platform_device *pdev = + container_of(hsotg->dev, struct platform_device, dev); + + printk(KERN_ERR "%s: pdev 0x%p\n", __func__, pdev);
Use pr_err() or even dev_err(). And is this really an error condition?
+ if (hsotg->plat->phy_init) + hsotg->plat->phy_init(pdev, S5P_USB_PHY_DEVICE); +}
WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html