On Tue, Mar 20, 2012 at 04:21:18PM +0530, Munegowda, Keshava wrote: > On Tue, Mar 20, 2012 at 3:29 PM, Felipe Balbi <balbi@xxxxxx> wrote: > > Hi, > > > > On Tue, Mar 20, 2012 at 03:00:50PM +0530, Munegowda, Keshava wrote: > >> >> +MODULE_AUTHOR("Keshava Munegowda <keshava_mgowda@xxxxxx>"); > >> >> +MODULE_ALIAS("platform:" USBHS_DRIVER_NAME); > >> >> +MODULE_LICENSE("GPL v2"); > >> >> +MODULE_DESCRIPTION("usb tll driver for TI OMAP EHCI and OHCI controllers"); > >> >> + > >> >> +static int __init omap_usbtll_drvinit(void) > >> >> +{ > >> >> + return platform_driver_probe(&usbtll_omap_driver, usbtll_omap_probe); > >> > > >> > please don't. Make sure you use platform_driver_register, instead. > >> > >> > >> Here , omap_usbtll_drvinit is registered through fs_initcall call; > >> this is required because, the TLL driver is required to initialized > >> before the UHH ( usb host core) driver. > > > > no issues with fs_initcall. The issue is with platform_driver_probe() > > only. > > > > -- > > balbi > > Thanks , I got it. > I will take the same comment make the same change in usbhs driver too; cool, thanks -- balbi
Attachment:
signature.asc
Description: Digital signature