Re: [PATCH] usb/usbmon: correct the data interpretation of usbmon's output

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 17 Mar 2012, Sebastian Andrzej Siewior wrote:

> The doc says that the data
> | 55534243 5e000000 00000000 00000600 00000000 00000000 00000000 000000
> is the SCSI command 0x5e. According to the usbmon source, it dumps one
> byte after the other. The first 4 bytes are US_BULK_CB_SIGN which is
> correct. After that we see the TAG which is 0x5e. The cdb is 0x00 in
> this example.
> In order to correct this, I change the example to a READ_10 command
> which is 0x28 so it is not just a zero somewhere in the stream.
> 
> Signed-off-by: Sebastian Andrzej Siewior <sebastian@xxxxxxxxxxxxx>
> ---
>  Documentation/usb/usbmon.txt |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/usb/usbmon.txt b/Documentation/usb/usbmon.txt
> index 5335fa8..c42bb9c 100644
> --- a/Documentation/usb/usbmon.txt
> +++ b/Documentation/usb/usbmon.txt
> @@ -183,10 +183,10 @@ An input control transfer to get a port status.
>  d5ea89a0 3575914555 S Ci:1:001:0 s a3 00 0000 0003 0004 4 <
>  d5ea89a0 3575914560 C Ci:1:001:0 0 4 = 01050000
>  
> -An output bulk transfer to send a SCSI command 0x5E in a 31-byte Bulk wrapper
> -to a storage device at address 5:
> +An output bulk transfer to send a SCSI command 0x28 (READ_10) in a 31-byte
> +Bulk wrapper to a storage device at address 5:
>  
> -dd65f0e8 4128379752 S Bo:1:005:2 -115 31 = 55534243 5e000000 00000000 00000600 00000000 00000000 00000000 000000
> +dd65f0e8 4128379752 S Bo:1:005:2 -115 31 = 55534243 ad000000 00800000 80010a28 20000000 20000040 00000000 000000
>  dd65f0e8 4128379808 C Bo:1:005:2 0 31 >
>  
>  * Raw binary format and API

Heh!  In spite of reading this file many times, I never noticed this 
mistake.

Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux