On Fri, 2012-03-16 at 13:20 +0800, Ming Lei wrote:
> +static void us_set_lock_class(struct mutex *mutex,
> + struct usb_interface *intf)
> +{
> + struct usb_device *udev = interface_to_usbdev(intf);
> + struct usb_host_config *config = udev->actconfig;
> + int i;
> +
> + if (config)
> + for (i = 0; i < config->desc.bNumInterfaces; i++)
> + if (config->interface[i] == intf) {
> + lockdep_set_class(mutex,
> + &us_interface_key[i]);
> + return;
> + }
> + dev_err(&intf->dev, "something weird!");
> +}
I'm not sure what the USB maintainers rules are, but I would object to
code like that. I very much prefer to see my curlies on code blocks
bigger than 1 line, even when they're a single statement and its not
strictly needed.
Anyway, the annotation seems ok, so if Greg doesn't object to your
coding style and takes it I won't object.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
