Re: [PATCH] ftdi_sio: add support for FT-X series devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Greg Kroah-Hartman wrote:
> On Wed, Mar 14, 2012 at 05:54:25PM -0400, Jim Paris wrote:
> > Add PID 0x6015, corresponding to the new series of FT-X chips
> > (FT220XD, FT201X, FT220X, FT221X, FT230X, FT231X, FT240X).  They all
> > appear as serial devices, and seem indistinguishable except for the
> > default product string stored in their EEPROM.  The baudrate
> > generation matches FT232RL devices.
> > 
> > Tested with a FT201X and FT230X at various baudrates (100 - 3000000).
> > 
> > Sample dmesg:
> >     ftdi_sio: v1.6.0:USB FTDI Serial Converters Driver
> >     usb 2-1: new full-speed USB device number 6 using ohci_hcd
> >     usb 2-1: New USB device found, idVendor=0403, idProduct=6015
> >     usb 2-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
> >     usb 2-1: Product: FT230X USB Half UART
> >     usb 2-1: Manufacturer: FTDI
> >     usb 2-1: SerialNumber: DC001WI6
> >     ftdi_sio 2-1:1.0: FTDI USB Serial Device converter detected
> >     drivers/usb/serial/ftdi_sio.c: ftdi_sio_port_probe
> >     drivers/usb/serial/ftdi_sio.c: ftdi_determine_type: bcdDevice = 0x1000, bNumInterfaces = 1
> >     usb 2-1: Detected FT-X
> >     usb 2-1: Number of endpoints 2
> >     usb 2-1: Endpoint 1 MaxPacketSize 64
> >     usb 2-1: Endpoint 2 MaxPacketSize 64
> >     usb 2-1: Setting MaxPacketSize 64
> >     drivers/usb/serial/ftdi_sio.c: read_latency_timer
> >     drivers/usb/serial/ftdi_sio.c: write_latency_timer: setting latency timer = 1
> >     drivers/usb/serial/ftdi_sio.c: create_sysfs_attrs
> >     drivers/usb/serial/ftdi_sio.c: sysfs attributes for FT-X
> >     usb 2-1: FTDI USB Serial Device converter now attached to ttyUSB0
> > 
> > Signed-off-by: Jim Paris <jim@xxxxxxxx>
> > ---
> > 
> > Unfortunately, the existing ftdi_determine_type considers anything
> > with bcdDevice >= 0x0900 to be a FT232H, which means that the baudrate
> > generation is incorrect if we just add a VID/PID.  Would this still be
> > appropriate for -stable?  Or maybe a stripped down version with just
> > the bare minimum to get it working (new VID/PID, and force FT232RL
> > chip type when bcdDevice == 0x1000)?
> > 
> >  drivers/usb/serial/ftdi_sio.c     |   20 +++++++++++++++-----
> >  drivers/usb/serial/ftdi_sio.h     |    3 ++-
> >  drivers/usb/serial/ftdi_sio_ids.h |    1 +
> >  3 files changed, 18 insertions(+), 6 deletions(-)
> 
> Such a "small" patch is fine for stable as-is.  Do you want me to take
> this one and mark it as such?
> 
> thanks,
> 
> greg k-h

Sure, thanks.

-jim


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux