Am Dienstag, 13. März 2012, 00:51:18 schrieb Matthew Garrett: > @@ -767,8 +777,10 @@ static int bcm5974_open(struct input_dev *input) > > mutex_unlock(&dev->pm_mutex); > > + usb_autopm_put_interface(dev->intf); > + > if (error) > - usb_autopm_put_interface(dev->intf); > + dev->intf->needs_remote_wakeup = 0; > > return error; Hi, optimally you'd drop the requirement for remote wakeup before you do the put operation. You might save an unneeded wakeup. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html