On Sunday 11 March 2012, Roland Stigge wrote: > Since this driver is compatible with several NXP devices, the driver is renamed > accordingly. Please combine with the following patch which also changes the > respective symbol names. > > Signed-off-by: Roland Stigge <stigge@xxxxxxxxx> > Hi Roland, As a general comment, it's helpful to use the "-M" flag to git-format-patch whenever you rename files, because that makes it obvious whether you have changed anything in the file or not. > --- /dev/null > +++ linux-2.6/drivers/usb/host/ohci-nxp.c > @@ -0,0 +1,453 @@ > +/* > + * drivers/usb/host/ohci-pnx4008.c > + * > + * driver for Philips PNX4008 USB Host > + * I think your second patch does not change this comment and probably should. Just remove the file name from the comment because that one is generally not helpful. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
