Hi, On 11/03/12 08:43, Wolfram Sang wrote: >>> And while we are at it: Could you also try replacing >>> i2c_write() with i2c_smbus_write_byte_data(isp1301_i2c_client, >>> reg, val)? >> >> Interestingly now, replacing i2c_write() calls with >> i2c_smbus_write_byte_data() did _not_ work (hardware >> initialization failure). I guess this is due to the differences >> between i2c and smbus, and the hardware only handles the former >> correctly? > > Did you take into consideration that the smbus-call has (client, > reg, val) as arguments while i2c_write has (val, reg), that is you > have to swap the arguments? Yes, that's it! :-) I'll update my patch to not use i2c_write() anymore. For the remaining i2c_write() in the current kernel driver, I will include an additional patch to remove it completely in favour of i2c_smbus_write_byte_data(). Thanks, Roland -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
