Re: [PATCH 1/3] usb/storage: a couple defines from drivers/usb/storage/transport.h to include/linux/usb/storage.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Pete Zaitcev | 2012-02-27 08:39:21 [-0700]:

>On Mon, 27 Feb 2012 10:16:29 -0500 (EST)
>Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:
>
>> On Sun, 26 Feb 2012, Sebastian Andrzej Siewior wrote: 
>
>> > This looks to me like there are some broken devices which work
>> > usb-storage but don't with ub. Therefore I suggest to add this driver
>> > to the removal list, add a prinkt that this driver will be removed.
>
>Be my guest, as long as you do the actual work on deprecation of removal.

Okay, will do.

>I did not hear from anyone actually using ub in a long time. Back in
>the day it saved quarter to a half a megabyte to drop the SCSI stack,
>so ub was employed by makers of arcade machines and the like. Nowadays
>nobody is going to scratch for a megabyte.

Well the embedded folks are crazy. They argue for weeks about 10 bytes.
It is 125KiB for scsi module and 25KiB for sd on only 14KiB for ub on
my i386. By deactivating the verbose thingy the scsi module goes down to
87KiB. So we talk here about 100KiB in best case 136KiB in worst case.
After a grep on the defconfig we have
- CONFIG_BLK_DEV_UB=m + CONFIG_USB_STORAGE=m in
  * arch/arm/configs/s3c2410_defconfig
  * arch/mips/configs/rm200_defconfig
  * arch/powerpc/configs/pmac32_defconfig

- CONFIG_BLK_DEV_UB=y
  * arch/mips/configs/db1200_defconfig
  * arch/mips/configs/db1300_defconfig
  * arch/mips/configs/pb1100_defconfig
  * arch/mips/configs/pb1500_defconfig
  * arch/mips/configs/pb1550_defconfig

So the former three have activated both so they hardly care about size
:). The 5 alchemy board look kinda odd. My best guess is that it was
activated the db1200 and the other got it via copy.

So let me prepare a patch for a removal as you suggested.

>
>-- Pete

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux