On Thu, Mar 01, 2012 at 09:33:03PM +0100, Linus Walleij wrote: > On Thu, Mar 1, 2012 at 8:26 PM, Alan Ott <alan@xxxxxxxxxxx> wrote: > > > From: Arnd Bergmann <arnd@xxxxxxxx> > > > > The driver should not call set_irq_flags itself, and > > cannot do this from a loadable module. > > > > Remove the call for now, which might break the driver > > but at least lets the kernel link again. > > > > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > > --- > > drivers/usb/host/ehci-tegra.c | 1 - > > 1 files changed, 0 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c > > index dbc7fe8..ab91f26 100644 > > --- a/drivers/usb/host/ehci-tegra.c > > +++ b/drivers/usb/host/ehci-tegra.c > > @@ -729,7 +729,6 @@ static int tegra_ehci_probe(struct platform_device *pdev) > > err = -ENODEV; > > goto fail; > > } > > - set_irq_flags(irq, IRQF_VALID); > > The kernel is full of this kind of stuff (drivers/mfd/twl4030-irq.c): > > #ifdef CONFIG_ARM > /* ARM requires an extra step to clear IRQ_NOREQUEST, which it > * sets on behalf of every irq_chip. Also sets IRQ_NOPROBE. > */ > set_irq_flags(irq, IRQF_VALID); > #else > /* same effect on other architectures */ > irq_set_noprobe(irq); > #endif > > Can't we try to fix this for real instead of breaking the universe, > hehe :-) That depends whether you want 0..NR_IRQS to all be request-able before they've been setup with their irq chips and handlers etc. Unfortunately, genirq doesn't provide a standard helper to clear IRQ_NOREQUEST, and that's why this pain persists. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
